[#IDEA-18363] More robust code in component saving

IDEA: Feedback

More robust code in component saving

Created: 07 Jun 08 16:22 Updated: 07 Jun 08 16:39

Component/s:

Plugin Support. Architecture

Build:	8,444
Severity:	Medium

Description

« Hide

If component throws Exception in saveState method, IDEA is fails to save project. Would nice to make code more robust: to catch throwable and to ignore saved state in this case.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Dmitry Jemerov - 07 Jun 08 16:31

This would hide errors. If you do not need to save the state of your component, return null from getState().

[ Permlink | « Hide ]

Konstantin Solomatov - 07 Jun 08 16:36

But If I have error somewhere it would be nice not to break everything. May be IDEA shouldn't save state at all in this case? All in all, in this case some reasonable error handling is better than lack of it.

BTW. In my experience of working with IDEA there are quite a lot of places where exception ruins everything (configurables is another one). It's enough to have one bad plugin or extension to make IDE unusable. IMO it's not very good.